[Bug 224354] [PATCH] graphics/imlib2: fix X11 dependency (again)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Dec 15 02:15:36 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224354

            Bug ID: 224354
           Summary: [PATCH] graphics/imlib2: fix X11 dependency (again)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: zeising at FreeBSD.org
          Reporter: dominik at honnef.co
          Keywords: patch
             Flags: maintainer-feedback?(zeising at FreeBSD.org)
          Assignee: zeising at FreeBSD.org

Created attachment 188849
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188849&action=edit
imlib2 patch fixing --without-x11 builds

When imlib2 is built without support for X11, Imlib2.h #includes X11/Xlib.h
conditionally, guarded by an #ifndef X_DISPLAY_MISSING – X_DISPLAY_MISSING,
however, isn't set, causing Imlib2.h to unsuccessfully include the header. This
was previously addressed in bug #187147 by patching Imlib2.h, but the patch
isn't working anymore, for two reasons.

1) When the Makefile was updated to use the new, conditional version of
post-patch, the condition was accidentally negated, applying the patch only
when imlib2 was being built *with* X11 support (bug #210609)

2) Whitespace around the macros in Imlib2.h changed.

The attached patch fixes both.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list