[Bug 223389] games/oolite: Update to 1.86

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223389

--- Comment #12 from lightside <lightside at gmx.com> ---
Probably, there is some misunderstanding here.
In my opinion, the comment #8 (as well as comment #6 and related answers) are
out of scope of this PR.
I guess, this is obvious, that submitted patches doesn't give (automatic)
rights to someone to demand inclusion of them to other places (from submitter).
The patches in "Ports & Packages" section of FreeBSD Bugzilla are intended for
FreeBSD ports/packages, after all. These patches maybe useful for other places,
of course, but this may have different issue(s) (and solution(s)).

Nevertheless, I tried to find a constructive meaning of what was said. So, I
tried to review some of the patches, which were added in ports r371389. At that
time, there were some efforts to build software with using available Clang
compiler on FreeBSD. Some of the issues were related to files in
deps/mozilla/js/src. It was found, that deps/mozilla contained (modified or
some version of) source code of SpiderMonkey 1.8.5 for Oolite:
https://github.com/OoliteProject/oolite/tree/1.80b/deps
https://github.com/OoliteProject/spidermonkey-ff4/blob/ca2fb5423fab4d72a3dc5fec911ce20bda01f223/README.txt

At the same time, there was available lang/spidermonkey185 port, which had
patches to fix Clang build issues in ports r320274.
First try was to use mozjs185 instead of js_static for LIBJS variable in
GNUmakefile, for example, by adding following changes to sed patch:
-8<--
                s|js_static|mozjs185| ; \
                s|$$(LIBJS_ROOT)/dist/include|$$(LOCALBASE)/include/js| ; \
                s|$$(LIBJS_ROOT)/dist|$$(LOCALBASE)| ; \
-->8-

But this produced following errors (current output was for Oolite 1.86
version):
-8<--
src/Core/Scripting/OOJSScript.m:(.text+0x52b): undefined reference to
`JS_DestroyScript'
src/Core/Scripting/OOJSScript.m:(.text+0x920): undefined reference to
`JS_XDRScript'
src/Core/Scripting/OOJSScript.m:(.text+0xa9e): undefined reference to
`JS_NewScriptObject'
src/Core/Scripting/OOJSScript.m:(.text+0xacf): undefined reference to
`JS_XDRScript'
-->8-

Maybe possible to fix them, but it was decided to backport/adapt (some of the)
patches from lang/spidermonkey185 to games/oolite port. This worked at that
time.

After some review, I guess, that possible to remove
files/patch-deps_mozilla-bug771281, which was related to following bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=771281
mainly because of different js.cpp and jsworkers.cpp files in
deps/mozilla/js/src/shell directory, compared to source code from
lang/spidermonkey185 port. But not sure about relation of following bug report
(i.e., whether Oolite affected or not):
https://bugzilla.mozilla.org/show_bug.cgi?id=705091

As I already said, I didn't (or can't) test patches for armv6 (or armv7). But
it was obvious to replace "-O" with "-O2" (for example) in case of aarch64.

-- 
You are receiving this mail because:
You are the assignee for the bug.