[Bug 221015] [NEW PORT] mail/mailhog: MailHog development mail server

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221015

Richard Gallamore <ultima at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ultima at freebsd.org

--- Comment #1 from Richard Gallamore <ultima at freebsd.org> ---
Hello, thanks you for your contributions and on this port. I found a few items
that needs to be adjusted before it is ready to be committed.


* Instead of including the bsd.port.pre.mk with an if, this could be made to
simply strip an i from the arch. ${ARCH:S/i//}. This should make it work with
both i386 and amd64.

* The USE_RC_SUBR belongs in the USES section and should come right after the
ONLY_FOR_ARCHS.

* Group similar variables together with a space for these items,
EXTRACT_*(excluding EXTRACT_SUFX), NO_* and *_FILES.

* The append flag on SUB_FILES is not needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.