[Bug 212849] games/osgg: Unbreak fetch, improve
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Tue Sep 20 11:08:15 UTC 2016
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212849
Bug ID: 212849
Summary: games/osgg: Unbreak fetch, improve
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Keywords: patch
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: amdmi3 at FreeBSD.org
Reporter: lightside at gmx.com
CC: amdmi3 at FreeBSD.org
Attachment #174999 maintainer-approval?(amdmi3 at FreeBSD.org)
Flags:
Flags: maintainer-feedback?(amdmi3 at FreeBSD.org)
Assignee: amdmi3 at FreeBSD.org
CC: amdmi3 at FreeBSD.org
Created attachment 174999
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=174999&action=edit
Proposed patch (since 422447 revision)
Patch to unbreak games/osgg and improve port.
- Unbreak fetch with using available distfile
- Adapt WRKSRC value
- Remove -f argument near ${RM} value
- Put cd related commands in parenthesis
- Regenerate distinfo file with using `make makesum` command and correct
TIMESTAMP value
Note about parenthesis for cd related commands:
-8<--
man make | grep "in parenthesis" -h5 | tail -8
Makefiles should be written so that the mode of make operation does not
change their behavior. For example, any command which needs to use "cd"
or "chdir", without side-effect should be put in parenthesis:
avoid-chdir-side-effects:
@echo Building $@ in `pwd`
@(cd ${.CURDIR} && ${.MAKE} $@)
-->8-
Note about ${RM} value and -f argument:
-8<--
make -C /usr/ports -V RM
/bin/rm -f
-->8-
How TIMESTAMP value was generated (for this case):
make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m' |
sort -u | tail -1 && make clean
or
make clean extract && find work/* -type f -exec stat -f '%m' {} + | sort -u |
tail -1 && make clean
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list