[Bug 208583] www/nginx: Prevent uninstallation breaking user symlink for /var/www/nginx

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208583

--- Comment #4 from Baptiste Daroussin <bapt at FreeBSD.org> ---
Your patch is ok, but there are plenty of other issues in that plist :)

for example:
%%WWWDATA%%@exec mkdir -p -m 755 %D/www/nginx-dist

should be 

@dir(,,555) www/nginx-dist

%%WWWDATA%%@exec if [ ! -d %D/www/nginx/ ] ; then ln -fs %D/www/nginx-dist
%D/www/nginx; fi


What happens for for any reason a user using nginx decided that %D/www/nginx
should be a file? it gets nuked :( during installation/upgrades

So this test should imho test for absence of any file/directory and only in
that case makes a symlink

%%WWWDATA%%@exec chmod a-w %D/www/nginx-dist
This is totally useless given the @dir is done (note the 555 and not the 755 on
the @dir

If I manage to find more time to properly test I will commit this Week End
along with your patch

-- 
You are receiving this mail because:
You are the assignee for the bug.