[Bug 212385] security/skipfish File /usr/local/share/skipfish/dictionaries/README-FIRST missing

Mon Sep 5 10:57:14 UTC 2016

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212385

            Bug ID: 212385
           Summary: security/skipfish File
                    /usr/local/share/skipfish/dictionaries/README-FIRST
                    missing
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: zi at FreeBSD.org
          Reporter: freebsd at g3os.org
          Assignee: zi at FreeBSD.org
             Flags: maintainer-feedback?(zi at FreeBSD.org)

Installing skipfish via ports says to review
/usr/local/share/skipfish/dictionaries/README-FIRST but the file isn't there. 
I think /usr/ports/security/skipfish/work/skipfish-2.10b/doc/dictionaries.txt
should get copied there, or the install message changed to where
dictionaries.txt is, etc.

EXPECTED 
========
less /usr/local/share/skipfish/dictionaries/README-FIRST describes the
dictionaries.

ACTUAL
======
root # less /usr/local/share/skipfish/dictionaries/README-FIRST
/usr/local/share/skipfish/dictionaries/README-FIRST: No such file or directory

I can't find the file in the build:
root # find /usr/ports/security/skipfish -name README-FIRST

There are four other files:
root # ls /usr/local/share/skipfish/dictionaries
complete.wl             extensions-only.wl      medium.wl              
minimal.wl

# man skipfish
...
DICTIONARY MANAGEMENT
       Make sure you've read the instructions provided in doc/dictionaries.txt
       to  select  the  right dictionary file and configure it correctly.
...

Perhaps ./work/skipfish-2.10b/doc/dictionaries.txt should be copied to
/usr/local/share/skipfish/dictionaries/README-FIRST.

root # less
/usr/ports/security/skipfish/work/skipfish-2.10b/doc/dictionaries.txt
This directory contains four alternative, hand-picked Skipfish dictionaries.

PLEASE READ THESE INSTRUCTIONS CAREFULLY BEFORE PICKING ONE. This is *critical*
to getting decent results in your scans.
...

STEPS TO REPRODUCE
==================

# cd /usr/ports/security/skipfish
# make install
===>  License APACHE20 accepted by the user
===>  Found saved configuration for skipfish-2.10b_3
===>   skipfish-2.10b_3 depends on file: /usr/local/sbin/pkg - found
=> skipfish-2.10b.tgz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://skipfish.googlecode.com/files/skipfish-2.10b.tgz
fetch: http://skipfish.googlecode.com/files/skipfish-2.10b.tgz: Not Found
=> Attempting to fetch
http://distcache.FreeBSD.org/ports-distfiles/skipfish-2.10b.tgz
skipfish-2.10b.tgz                            100% of  238 kB  122 kBps 00m01s
===> Fetching all distfiles required by skipfish-2.10b_3 for building
===>  Extracting for skipfish-2.10b_3
=> SHA256 Checksum OK for skipfish-2.10b.tgz.
===>  Patching for skipfish-2.10b_3
===>  Applying FreeBSD patches for skipfish-2.10b_3
===>   skipfish-2.10b_3 depends on executable: gmake - found
===>   skipfish-2.10b_3 depends on shared library: libidn.so - found
(/usr/local/lib/libidn.so)
===>   skipfish-2.10b_3 depends on shared library: libpcre.so - found
(/usr/local/lib/libpcre.so)
===>  Configuring for skipfish-2.10b_3
===>  Building for skipfish-2.10b_3
gmake[2]: Entering directory '/usr/ports/security/skipfish/work/skipfish-2.10b'
cc -L/usr/home/me/src/boost/boost_1_61_0/stage/lib  -L/usr/local/lib
src/skipfish.c -o skipfish \
        -O3 -Wno-format -Wall -funsigned-char -g -ggdb -I/usr/local/include/
-pipe  -g -fno-strict-aliasing -DVERSION=\"2.10b\" src/http_client.c
src/database.c src/crawler.c src/analysis.c src/report.c src/checks.c
src/signatures.c src/auth.c src/options.c  -lcrypto -lssl -lidn -lz -lpcre
src/signatures.c: In function 'check_signature':
src/signatures.c:83: warning: comparison is always false due to limited range
of data type
gmake[2]: Leaving directory '/usr/ports/security/skipfish/work/skipfish-2.10b'
===>  Staging for skipfish-2.10b_3
===>   Generating temporary packing list
install   -m 555 /usr/ports/security/skipfish/work/skipfish-2.10b/skipfish
/usr/ports/security/skipfish/work/stage/usr/local/bin/skipfish
install  -m 555
/usr/ports/security/skipfish/work/skipfish-2.10b/tools/sfscandiff
/usr/ports/security/skipfish/work/stage/usr/local/bin/sfscandiff
install  -m 444 /usr/ports/security/skipfish/work/skipfish-2.10b/doc/skipfish.1
/usr/ports/security/skipfish/work/stage/usr/local/man/man1
(cd /usr/ports/security/skipfish/work/skipfish-2.10b/assets/ && /bin/sh -c
'(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >/dev/null  2>&1) && 
/usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; &&  /usr/bin/find -d $0
$2 -type f -exec chmod 444 $1/{} \;' -- .
/usr/ports/security/skipfish/work/stage/usr/local/share/skipfish/assets/)
(cd /usr/ports/security/skipfish/work/skipfish-2.10b/dictionaries/ && /bin/sh
-c '(/usr/bin/find -d $0 $2 | /usr/bin/cpio -dumpl $1 >/dev/null  2>&1) && 
/usr/bin/find -d $0 $2 -type d -exec chmod 755 $1/{} \; &&  /usr/bin/find -d $0
$2 -type f -exec chmod 444 $1/{} \;' -- .
/usr/ports/security/skipfish/work/stage/usr/local/share/skipfish/dictionaries/)
/bin/mkdir -p
/usr/ports/security/skipfish/work/stage/usr/local/share/doc/skipfish
install  -m 0644 /usr/ports/security/skipfish/work/skipfish-2.10b/README
/usr/ports/security/skipfish/work/stage/usr/local/share/doc/skipfish
install  -m 0644 /usr/ports/security/skipfish/work/skipfish-2.10b/COPYING
/usr/ports/security/skipfish/work/stage/usr/local/share/doc/skipfish
install  -m 0644 /usr/ports/security/skipfish/work/skipfish-2.10b/ChangeLog
/usr/ports/security/skipfish/work/stage/usr/local/share/doc/skipfish
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
===>  Installing for skipfish-2.10b_3
===>  Checking if skipfish already installed
===>   Registering installation for skipfish-2.10b_3
Installing skipfish-2.10b_3...
******************************************************************
The FreeBSD port is configured to use the "default" dictionary but
it's highly recommended to read the dictionaries document first in
order to pick the right dictionary

/usr/local/share/skipfish/dictionaries/README-FIRST

The skipfish dictionaries have been installed in the following
directory:

/usr/local/share/skipfish/dictionaries/
******************************************************************

SYSTEM INFORMATION
==================
# uname -a
FreeBSD g5.local 10.3-RELEASE FreeBSD 10.3-RELEASE #0 r297264: Fri Mar 25
05:57:04 UTC 2016    
root at releng1.nyi.freebsd.org:/usr/obj/powerpc.powerpc64/usr/src/sys/GENERIC64 
powerpc

Thank you,
- d

-- 
You are receiving this mail because:
You are the assignee for the bug.