[Bug 213587] net-p2p/go-ethereum: Update to 1.4.18

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213587

--- Comment #3 from Kubilay Kocak <koobs at FreeBSD.org> ---
(In reply to Fynn from comment #2)

Having looked at Makefile and pkg-plist in the repository it looks OK
(syntactically). 

Having said that I'm not sure I would provide an option for every single
binary, but that would depend on the size of the binaries and whether or not
there was a good case to be made for 'most users only want to install a subset'
based on a general/majority use-case.

Points also go against the need for options for each one given:

- None of the options require additional dependencies, or any build time
changes.
- None of the options are enabled by default, meaning the binary package of the
port has much less utility by default.

I would also clarify some of the OPTIONS_DESC's. For example:

BOOTNODE_DESC= Runs a bootstrap node for the Discovery Protocol

BOOTNODE does not appear to 'run' a bootstrap node, but it does install another
binary (unclear).

Maybe something like "bootstrap(8): Node for the Discovery Protocol

Perhaps its worth prefixing the binary name to all OPTION_DESC's like above.

Also consider grouping all of these into a OPTIONS_GROUP=UTILITIES with a
UTILITIES_DESC=Optional Tools/Utilities, so that is further clear what they all
are.

-- 
You are receiving this mail because:
You are the assignee for the bug.