[Bug 214381] ports make install doesn't handle symbolic links correctly

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214381

tech-lists at zyxst.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tech-lists at zyxst.net

--- Comment #11 from tech-lists at zyxst.net ---
(In reply to Tijl Coosemans from comment #10)

This does not appear to be the same bug. I applied your patch and now I get:

john at pumpkin:~ % rm -rf dir2
john at pumpkin:~ % mkdir dir2
john at pumpkin:~ % ln -s dir2 dir
john at pumpkin:~ % touch dir/file
john at pumpkin:~ % ln dir/file dir/file2
john at pumpkin:~ % tar cf dir.tar dir/file dir/file2
john at pumpkin:~ % rm dir/*
john at pumpkin:~ % tar xf dir.tar -P
john at pumpkin:~ % ls -l dir/
total 1
-rw-r--r--  2 john  john  0 25 Nov 23:42 file
-rw-r--r--  2 john  john  0 25 Nov 23:42 file2
john at pumpkin:~ % 

[works as expected]

This is on 11.0-STABLE #0 r308922 & ports r427130

however I still have problems with installing (some, not all) ports such as
portupgrade:

root at pumpkin:/root# which portupgrade
/usr/local/sbin/portupgrade
root at pumpkin:/root# pkg delete portupgrade
Updating database digests format: 100%
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages
in the universe):

Installed packages to be REMOVED:
        portupgrade-2.4.14,2

Number of packages to be removed: 1

Proceed with deinstalling packages? [y/N]: y
[1/1] Deinstalling portupgrade-2.4.14,2...
[1/1] Deleting files for portupgrade-2.4.14,2: 100%
root at pumpkin:/root# which portupgrade
portupgrade: Command not found.
root at pumpkin:/root# cd /usr/ports/ports-mgmt/portupgrade
root at pumpkin:/usr/ports/ports-mgmt/portupgrade# make
===>  License BSD3CLAUSE accepted by the user

[...]

bin/mkdir -p
/storage/usr/ports/ports-mgmt/portupgrade/work/stage/usr/local/share/zsh/site-functions
install  -o root -g wheel  -m 444 _pkgtools
/storage/usr/ports/ports-mgmt/portupgrade/work/stage/usr/local/share/zsh/site-functions/
/bin/mkdir -p
/storage/usr/ports/ports-mgmt/portupgrade/work/stage/usr/local/share/doc/pkgtools
install -c -o root -g wheel -m 444  NEWS.md README.md
/storage/usr/ports/ports-mgmt/portupgrade/work/stage/usr/local/share/doc/pkgtools
/bin/mkdir -p
/storage/usr/ports/ports-mgmt/portupgrade/work/stage/usr/local/lib/compat/pkg
====> Compressing man pages (compress-man)
===>   Installing ldconfig configuration file

root at pumpkin:/usr/ports/ports-mgmt/portupgrade# make install
===>  Installing for portupgrade-2.4.14,2
===>   portupgrade-2.4.14,2 depends on file: /usr/local/bin/ruby22 - found
===>   portupgrade-2.4.14,2 depends on file:
/usr/local/lib/ruby/site_ruby/2.2/amd64-freebsd11/bdb.so - found
===>  Checking if portupgrade already installed
===>   Registering installation for portupgrade-2.4.14,2
Installing portupgrade-2.4.14,2...
root at pumpkin:/usr/ports/ports-mgmt/portupgrade# 

root at pumpkin:/usr/ports/ports-mgmt/portupgrade# which portupgrade
portupgrade: Command not found.

Instead, I have to install it like this:

make clean package deinstall && pkg add work/pkg/* && make clean

Installing portupgrade-2.4.14,2...
Extracting portupgrade-2.4.14,2: 100%
===>  Cleaning for portupgrade-2.4.14,2
root at pumpkin:/usr/ports/ports-mgmt/portupgrade# which portupgrade              
/usr/local/sbin/portupgrade
root at pumpkin:/usr/ports/ports-mgmt/portupgrade#

-- 
You are receiving this mail because:
You are on the CC list for the bug.