[Bug 214638] devel/kore: fails to build on 12.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214638

Tobias Kortkamp <t at tobik.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177182|                            |maintainer-approval+
              Flags|                            |

--- Comment #3 from Tobias Kortkamp <t at tobik.me> ---
Created attachment 177182
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=177182&action=edit
kore.diff

I currently see three ways to fix this, but I'm unsure which one is the
correct one:

(1) Add #undef basename to src/cli.c, so that it always uses the new
    basename without having to use _Generic

(2) Add -Wno-error=c11-extensions to CFLAGS.  This breaks the build
    with gcc (since it doesn't know about -Wno-error) and on FreeBSD 9.3,
    but at least we don't just silence the warning.  Building on FreeBSD
    9.3 could be fixed by building with clang from ports, but I'm more
    inclined to just mark it broken.

(3) Use -std=c11 instead of -std=c99.  I'm unsure what -std=c11
    actually implies, probably more than just -Wno-c11-extensions.

I'm leaning towards (2) and the patch is for that approach.  It should also fix
building with clang 3.9 (bug #214639).

-- 
You are receiving this mail because:
You are the assignee for the bug.