[Bug 213939] [NEW PORT] games/EmptyEpsilon: A spaceship bridge simulator game

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213939

Jan Beich (mail not working) <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich at FreeBSD.org

--- Comment #3 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
Comment on attachment 176359
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176359
shar archive

> XLICENSE_FILE=	${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
                                  ^^^^^^^^^^^^
Why not ${WRKSRC}/LICENSE ? Otherwise, maybe substitute one more word e.g.,

  -LICENSE_FILE=        ${WRKDIR}/EmptyEpsilon-${DISTVERSIONFULL}/LICENSE
  +LICENSE_FILE=        ${WRKDIR}/${GH_PROJECT}-${DISTVERSIONFULL}/LICENSE

> XLIB_DEPENDS=	libsfml-system.so:devel/sfml

Fixed in ports r425104, so EmptyEpsilon builds fine on 9.x. ;)

> XCMAKE_ARGS=	-DSERIOUS_PROTON_DIR=../SeriousProton-${DISTVERSIONFULL}/

To make it less fragile maybe use WRKSRC_<group> e.g.,

  -CMAKE_ARGS=  -DSERIOUS_PROTON_DIR=../SeriousProton-${DISTVERSIONFULL}/
  +CMAKE_ARGS=  -DSERIOUS_PROTON_DIR="${WRKSRC_sproton}/"

> XPATCH_WRKSRC=	${WRKDIR}

Why? Only post-patch below touches the files outside of WRKSRC.

> Xpost-patch:
> X	@${REINPLACE_CMD} -e 's|basepath + |"${PREFIX}/share/emptyepsilon/" + basepath + |' \
> X		${WRKDIR}/SeriousProton-*/src/resources.cpp
> X	@${REINPLACE_CMD} -e 's|loadFromFile("resources/"|loadFromFile("${PREFIX}/share/emptyepsilon/resources/"|' \
> X		${WRKDIR}/SeriousProton-*/src/postProcessManager.cpp

Can you keep letter case consistent: bin/EmptyEpsilon vs. share/emptyepsilon
vs. ~/.emptyepsilon ? If you pick lower case rename the port to match it e.g.,

  -PORTNAME=      EmptyEpsilon
  +PORTNAME=      emptyepsilon
  ...
  -GH_ACCOUNT=    daid
  +GH_TUPLE+=     daid:EmptyEpsilon:${DISTVERSIONFULL}

> sed 's/^X//' >games/EmptyEpsilon/pkg-descr << '930a933c75becaad7502e40f41a5a7c0'
> XEmptyEpsilon is a spaceship bridge simulator game.

The first line in pkg-descr can be dropped as it matches ${COMMENT} in Makefile
and is obvious from reading the rest.

-- 
You are receiving this mail because:
You are the assignee for the bug.