[Bug 213985] science/avogadro: fix for lang/gcc5

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213985

--- Comment #1 from Gerald Pfeifer <gerald at FreeBSD.org> ---
Thanks for looking into this, Kenneth!

I am not familiar with this port, nor even Eigen, so I hope some other
committer will grab this, but one comment/suggestion on this patch:

++// fix for lang/gcc5
++#if __GNUC__ == 5 && __GNUC_MINOR__ == 4
++#undef minor
++#endif

Why check for __GNUC_MINOR__, especially with ==?  What if the lang/gcc5
port is updated to version 5.5?

Wouldn't it be best to just check for __GNUC__, ignoring __GNUC_MINOR__,
and perhaps even __GNUC__ >= 5?

-- 
You are receiving this mail because:
You are the assignee for the bug.