[Bug 207875] fetch-list does not store into DIST_SUBDIR

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207875

            Bug ID: 207875
           Summary: fetch-list does not store into DIST_SUBDIR
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: darius at dons.net.au
                CC: freebsd-ports-bugs at FreeBSD.org

I use fetch-recursive-list to get distfiles to non-networked jails, however I
have to move anything using DIST_SUBDIR manually as it just puts them in CWD.

Perusing fetch-list I see...

                                DIR=${DIST_SUBDIR};\
                                CKSIZE=`alg=SIZE; ${DISTINFO_DATA}`; \
                                case $${file} in \
                                */*)    args="-o $${file} $${site}$${file}";; \
                                *)              args=$${site}$${file};; \
                                esac; \
                                ${ECHO_CMD} -n ${SETENV} ${FETCH_ENV}
${FETCH_CMD} ${FETCH_BEFORE_ARGS} $${args} "${FETCH_AFTER_ARGS}" '|| ' ; \

Which looks odd as 'DIR' is never used - was this feature removed or broken by
mistake?

I would expect (ho ho ho) it to be relatively easy to check if DIST_SUBDIR is
set and if so add something like if [ ! -d ${DIST_SUBDIR} ]; then; mkdir
${DIST_SUBDIR}; fi; ( cd ${DIST_SUBDIR} ; .... )

-- 
You are receiving this mail because:
You are on the CC list for the bug.