[Bug 207291] net/asterisk-chan_sccp: Version bump to v4.2.3

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207291

--- Comment #11 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
(In reply to Diederik de Groot from comment #10)
> (In reply to Raphael Kubo da Costa from comment #9)
> I have changed the source code to include "config.h" in both source files,
> which should have taken care of the issue reported.
>
> I am not sure if 9.3 does include iconv in the same way that 10.2 does. But
> even if not provided, then configure should have detected that and not set
> ICONV_CONST. I have test this on my local system (with and without iconv),
> which compiled cleanly.

iconv support is a problematic topic: basically in 9.x we still shipped with
iconv(3) that used a const in the second argument, which doesn't match most
implementations out there. This has been fixed in 10.x+, which is why you
didn't see any problems in your tests. Mk/Uses/iconv.mk contains all the hairy
details that make USES=iconv work on all supported FreeBSD versions.

The whole build issue is happening because the configure script was considering
iconv was not installed even though it is present and must be used. The
ICONV_CONST macro was then not being defined anywhere and the compiler thought
it was a symbol it did not recognize.

This is caused by the way the iconv m4 and autotools code is written:
--with-libiconv-prefix=${LOCALBASE} (which is what you get with
${ICONV_CONFIGURE_ARG}) is not enough and the iconv(3) detection code only
works when iconv's include path and library are passed to the compiler/linker.

This can be fixed by adding a few more variables to the Makefile:
    CPPFLAGS+=-I${ICONV_INCLUDE_PATH}
    LDFLAGS+= -L${LOCALBASE}/lib ${ICONV_LIB}

-- 
You are receiving this mail because:
You are the assignee for the bug.