[Bug 207657] games/fairymax: Update to 5.0b

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207657

Raphael Kubo da Costa <rakuco at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakuco at FreeBSD.org

--- Comment #4 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
Hi Kalten,

I have some suggestions for your update:
- share/games/plugins looks like a very generic directory for fairymax to use.
How about setting |plugindir| to ${DATADIR}/plugins in MAKE_ARGS.
- INI_Q already seems to be set to ${DATADIR}/qmax.ini since you set fairydir
to ${DATADIR}, so I guess you don't need to explicitly set it.
- "-O2" doesn't really justify having an OPTIMIZED_CFLAGS option. It's passed
by default by the ports tree along with "-pipe -fstack-protector
-fno-strict-aliasing".
- The fairymax.pod sed call doesn't seem to be replacing anything in this
version.
- fairymax's Makefile already has an install target, do you really need to have
a custom do-install target yourself?

-- 
You are receiving this mail because:
You are the assignee for the bug.