[Bug 207715] [NEW PORT]: archivers/py-borgbackup: Deduplicating backup program

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207715

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koobs at FreeBSD.org
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
            Summary|New port:                   |[NEW PORT]:
                   |archivers/py-borgbackup:    |archivers/py-borgbackup:
                   |Deduplicating backup        |Deduplicating backup
                   |program                     |program

--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
The PACKAGE_BUILDING check looks like a copy of what was added to
www/py-aiohttps in r388656 [1], that I just removed [2] due to it being a 3.x+
port, and the package builders only building for 2.7 (the DEFAULT_VERSION).

What instead needs to happen is that this ports dependencies need to have py3-*
versions created for them (very very very unfortunately).



Other review items:

* Missing PKGNAMEPREFIX=PYTHON_PKGNAMEPREFIX
* PORTVERSION needs to be DISTVERSION for this version string
* post-install STRIP_CMD can use *.so instead of a for loop and should use
PYTHONPREFIX_SITELIBDIR
* Upstream says the minimum Python versions is 3.4 [3]
* Use ${PYTHON_PKGNAMEPREFIX}name>=x.y for RUN_DEPENDS instead of on the .so
files [4]
* Missing BUILD_DEPENDS on setuptools_scm [5]
* I see no "requires" reference to pylibacl. If this is *actually* needed, send
a patch upstream

[1] https://svnweb.freebsd.org/changeset/ports/388656
[2] https://svnweb.freebsd.org/changeset/ports/410169
[3] https://github.com/borgbackup/borg/blob/master/setup.py#L10
[4] install_requires = ['msgpack-python>=0.4.6', ]
[5] setup_requires=['setuptools_scm>=1.7'],

-- 
You are receiving this mail because:
You are the assignee for the bug.