[Bug 210404] [NEW PORT] graphics/hiptext: Tool for rendering images and videos inside terminals

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210404

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich at FreeBSD.org

--- Comment #2 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 171601
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171601
shar archive

Fails to build on 9.x. It wants USES=compiler:c++11-lib. If you really need
C++14 features submit a bug for USES=compiler:c++14-lib or make a conditional
after bsd.port.options.mk. However, it builds fine on 9.x and 10.1 with just
C++11.

  In file included from hiptext.cc:17:
  ./artiste.h:15:30: error: no type named 'function' in namespace 'std'
  using RenderAlgorithm = std::function<void(std::ostream&, const Graphic&)>;
                          ~~~~~^
  In file included from hiptext.cc:23:
  ./macterm.h:7:10: fatal error: 'cstdint' file not found
  #include <cstdint>
           ^

Fails to build with devel/googletest installed. Add CONFLICTS_BUILD, manage
*FLAGS or use system gtest per
https://www.freebsd.org/doc/en/books/porters-handbook/bundled-libs.html

  In file included from gtest/src/gtest-all.cc:42:
  gtest/src/gtest.cc:958:23: error: out-of-line definition of 'swap' does not
match any declaration in
        'testing::AssertionResult'
  void AssertionResult::swap(AssertionResult& other) {
                        ^~~~
  gtest/src/gtest.cc:961:3: error: no matching function for call to 'swap'
    swap(message_, other.message_);
    ^~~~
  In file included from gtest/src/gtest-all.cc:42:
  gtest/src/gtest.cc:991:13: error: use of undeclared identifier 'EditType'
  std::vector<EditType> CalculateOptimalEdits(const std::vector<size_t>& left,
              ^

Fails to build with ffmpeg 3.0 (bug 207547). Try s/PIX_FMT/AV_&/ +
s/avcodec_alloc_frame/av_frame_alloc/

  movie.cc:56:42: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you
mean
        'AV_PIX_FMT_RGB24'?
                          width_, height_, PIX_FMT_RGB24, SWS_FAST_BILINEAR,
                                           ^~~~~~~~~~~~~
                                           AV_PIX_FMT_RGB24
  movie.cc:64:18: error: use of undeclared identifier 'avcodec_alloc_frame'
    CHECK(frame_ = avcodec_alloc_frame());
                   ^

> XPORTVERSION=	0.160620

Do not abbreviate snapshot year to avoid confusion about the date format
(%y%m%d vs. %d%m%y).
And prepend one more 0. to avoid PORTEPOCH issue in case upstream releases 0.1.

> X		libpng16.so:graphics/png \

Depend on libpng.so unless it won't build/work with libpng17.

> XCXXFLAGS+=	-I${PREFIX}/include -I${PREFIX}/include/freetype2

PREFIX is where *this* port installs, use LOCALBASE otherwise. In some cases
the destination can be empty: poudriere testport -P ...

After that consider replacing -I${LOCALBASE}/include with USES=localbase.

> XPLIST_FILES=	bin/hiptext %%DATADIR%%/DejaVuSansMono.ttf
> X
> Xpost-patch:
> X	@${REINPLACE_CMD} -e 's|"DejaVuSansMono.ttf"|"${PREFIX}/share/${PORTNAME}/DejaVuSansMono.ttf"|' \
> X		${WRKSRC}/font.cc
> Xdo-install:
> X	(cd ${WRKSRC} && \

Why do you need to change directory just to run commands that work fine with
absolute paths?

> X		${INSTALL_DATA} DejaVuSansMono.ttf ${STAGEDIR}${PREFIX}/share/${PORTNAME})

Use DejaVuSansMono.ttf from x11-fonts/dejavu unless the port needs modified
version.

> Xdo-test:
> X	(cd ${WRKSRC} && \
> X		${MAKE_CMD} test && ./test)

Define TEST_TARGET=check instead to avoid losing MAKE_ENV/MAKE_ARGS/MAKE_JOBS
etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.