[Bug 210026] emulators/xsystem35: broken by sys/shm.h namespace pollution

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210026

            Bug ID: 210026
           Summary: emulators/xsystem35: broken by sys/shm.h namespace
                    pollution
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: regression
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: jbeich at FreeBSD.org
                CC: ed at FreeBSD.org

Created attachment 171014
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171014&action=edit
v0

After base r301074 the port fails to build as machine/param.h defines
INKERNEL() which is used by sys/soundcard.h to hide SEQ_* macros. My guess, the
check is an artifact before _KERNEL was consistently defined.

  midi.rawmidi.c:250:15: error: expected parameter declarator
  SEQ_DEFINEBUF(2048);
                ^
  midi.rawmidi.c:250:15: error: expected ')'
  midi.rawmidi.c:250:14: note: to match this '('
  SEQ_DEFINEBUF(2048);
               ^
  midi.rawmidi.c:250:1: warning: type specifier missing, defaults to 'int'
[-Wimplicit-int]
  SEQ_DEFINEBUF(2048);
  ^
  midi.rawmidi.c:251:1: warning: type specifier missing, defaults to 'int'
[-Wimplicit-int]
  SEQ_USE_EXTBUF();
  ^
  midi.rawmidi.c:255:6: error: use of undeclared identifier '_seqbufptr'; did
you mean 'setbuffer'?
          if (_seqbufptr) {
              ^~~~~~~~~~
              setbuffer
  /usr/include/stdio.h:411:7: note: 'setbuffer' declared here
  void     setbuffer(FILE *, char *, int);
           ^
  midi.rawmidi.c:255:6: warning: address of function 'setbuffer' will always
evaluate to 'true' [-Wpointer-bool-conversion]
          if (_seqbufptr) {
          ~~  ^~~~~~~~~~
  midi.rawmidi.c:255:6: note: prefix with the address-of operator to silence
this warning
          if (_seqbufptr) {
              ^
              &
  midi.rawmidi.c:256:21: error: use of undeclared identifier '_seqbuf'; did you
mean 'setbuf'?
                  if (write(midifd, _seqbuf, _seqbufptr) == -1) {
                                    ^~~~~~~
                                    setbuf
  /usr/include/stdio.h:273:7: note: 'setbuf' declared here
  void     setbuf(FILE * __restrict, char * __restrict);
           ^
  midi.rawmidi.c:256:30: error: use of undeclared identifier '_seqbufptr'; did
you mean 'setbuffer'?
                  if (write(midifd, _seqbuf, _seqbufptr) == -1) {
                                             ^~~~~~~~~~
                                             setbuffer
  /usr/include/stdio.h:411:7: note: 'setbuffer' declared here
  void     setbuffer(FILE *, char *, int);
           ^
  midi.rawmidi.c:261:2: error: use of undeclared identifier '_seqbufptr'
          _seqbufptr = 0;
          ^
  midi.rawmidi.c:294:3: warning: implicit declaration of function 'SEQ_MIDIOUT'
is invalid in C99 [-Wimplicit-function-declaration]
                  SEQ_MIDIOUT(midi_subdev, *(d++));
                  ^

http://beefy3.nyi.freebsd.org/data/head-i386-default/p416265_s301181/logs/errors/xsystem35-1.7.3.p5_2.log

-- 
You are receiving this mail because:
You are the assignee for the bug.