[Bug 211347] [NEW PORT] devel/py-numba: LLVM optimizing compiler for python and is numpy aware

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211347

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(dave at d
                   |                            |al.ca)
            Summary|New port: devel/py-numba |  |[NEW PORT] devel/py-numba:
                   |Numba is a LLVM optimizing  |LLVM optimizing compiler
                   |compiler for python and is  |for python and is numpy
                   |numpy aware                 |aware
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa, patch
         Depends on|                            |211346
                 CC|                            |dave at dal.ca
             Status|New                         |Open

--- Comment #6 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks David,

Minor nits (as long as you've already run portlint -AC):

* Remove "Numba is an" from the COMMENT

See:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-comment

* BUILD_DEPENDS+=      
${PYTHON_PKGNAMEPREFIX}numpy>1.7:${PORTSDIR}/math/py-numpy

Change to = (its not appending anything) and put it above USES section (after
LICENSE as it doesn't need anything that pre.mk provides so goes before the
include. This is unlike the conditional RUN_DEPENDS, which uses PYTHON_REL,
which *does* need to be after pre.mk.

Also ${PORTSDIR}/ is no longer required for dependency lines

* Unconditional RUN_DEPENDS (llvmlite/argparse) go up top along with other
*_DEPENDS


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211346
[Bug 211346] [NEW PORT] devel/py-llvmlite: Lightweight LLVM python binding for
writing JIT compilers
-- 
You are receiving this mail because:
You are the assignee for the bug.