[Bug 210545] [NEW PORT] devel/riemann-c-client: C client library for the Riemann monitoring system

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210545

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich at FreeBSD.org

--- Comment #1 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 171768
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=171768
SHAR file

Install ports-mgmt/portlint and make sure it doesn't complain. In this case all
are true positives.

  $ portlint -AC
  WARN: devel/riemann-c-client/pkg-plist: [11]: installing shared libraries,
please define USE_LDCONFIG as appropriate
  WARN: devel/riemann-c-client/pkg-plist: [12]: installing shared libraries,
please define USE_LDCONFIG as appropriate
  FATAL: devel/riemann-c-client/pkg-plist: [14]: installing pkg-config files
into lib/pkgconfig.  All pkg-config files must be installed into
libdata/pkgconfig for them to be found by pkg-config.
  FATAL: Makefile: [10]: use a tab (not space) after a variable name
  FATAL: Makefile: [11]: use a tab (not space) after a variable name
  FATAL: Makefile: [29]: use a tab (not space) after a variable name
  4 fatal errors and 2 warnings found.

The port fails to build inside poudriere as pkgconfig isn't installed.

  ===>  Configuring for riemann-c-client-1.9.0
  libtoolize: putting auxiliary files in '.'.
  libtoolize: copying file './ltmain.sh'
  libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
  libtoolize: copying file 'm4/libtool.m4'
  libtoolize: copying file 'm4/ltoptions.m4'
  libtoolize: copying file 'm4/ltsugar.m4'
  libtoolize: copying file 'm4/ltversion.m4'
  libtoolize: copying file 'm4/lt~obsolete.m4'
  configure.ac:25: error: possibly undefined macro: AC_MSG_ERROR
        If this token and others are legitimate, please use m4_pattern_allow.
        See the Autoconf documentation.
  configure.ac:44: error: possibly undefined macro: dnl
  configure.ac:51: error: possibly undefined macro: AC_CHECK_LIB
  autoreconf-2.69: /usr/local/bin/autoconf-2.69 failed with exit status: 1
  *** [do-autoreconf] Error code 1

Even successful build needs attention.

  ====> Running Q/A tests (stage-qa)
  Warning: 'lib/libriemann-client.so.0.9.0' is not stripped consider trying
INSTALL_TARGET=install-strip or using ${STRIP_CMD}

> XBUILD_DEPENDS=	libtool>=2.2:devel/libtool \
> X		protobuf-c>=1.2.1:devel/protobuf-c \
> X		gnutls>=2.8.0:security/gnutls \
> X		json-c>=0.12:devel/json-c
> XRUN_DEPENDS=	libtool>=2.2:devel/libtool \
> X		protobuf-c>=1.2.1:devel/protobuf-c \
> X		gnutls>=2.8.0:security/gnutls \
> X		json-c>=0.12:devel/json-c

Convert to LIB_DEPENDS, at least RUN_DEPENDS.

USES=libtool already covers BUILD_DEPENDS=libtool. Why do you need libtool at
runtime as well?

> XGH_PROJECT=	riemann-c-client

GH_PROJECT is by default the same as PORTNAME.

> XGH_TAGNAME=	riemann-c-client-${PORTVERSION}

Convert to DISTVERSIONPREFIX.

> XUSES=	gmake autoreconf libtool
> XGNU_CONFIGURE=	yes
> XUSE_AUTOTOOLS=  autoheader:env

Mixing USES=autoreconf with USE_AUTOTOOLS is not supported. Pick either one but
note USE_AUTOTOOLS is deprecated.

  $ echo DEVELOPER=1 >>/etc/make.conf
  $ make
  /!\ riemann-c-client-1.9.0: Makefile warnings, please consider fixing /!\

  USE_AUTOTOOLS is deprecated, please use USES=autoreconf and GNU_CONFIGURE=yes
  [...]

> XCPPFLAGS+=	-I${LOCALBASE}/include

Convert to USES=localbase.

-- 
You are receiving this mail because:
You are the assignee for the bug.