[Bug 210991] [MAINTAINER][PATCH] astro/gpsbabel Fix build with libc++ 3.8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210991

            Bug ID: 210991
           Summary: [MAINTAINER][PATCH] astro/gpsbabel Fix build with
                    libc++ 3.8.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: dev2 at heesakkers.info
          Keywords: patch

Created attachment 172361
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172361&action=edit
patch to patch exif.cc

Ever since libc++ 3.8.0 was introduced, I've had pkg fallout bugging me about
this. See #208158

Initially I wanted to combine the update to 1.5.3 with a fix for this problem,
but to my surprise the update was already done through phabricator by the time
I got to it (I know I'm late to update, but not even a courtesy e-mail?).

The original complaint from pkg fallout was "call to 'abs' is ambiguous" and
only leads to a failed build under i386.

Replacing abs() with labs(), as is done upstream, would fix the build, but
warnings would still be displayed.

Since the problem is presumably caused by QT's toTime_t() I then figured it
would be appropriate to replace abs() with QT's qAbs(). The build now completes
without error or warning on i386 and completes without error but with a warning
on amd64 ("format specifies type 'int' but the argument).

Since this warning is only on printing a warning I figured I'd get patch in as
is and try to address this warning later when I get the chance.

Tested against i386 and amd64 1100120.

-- 
You are receiving this mail because:
You are the assignee for the bug.