[Bug 210450] [NEW PORT] devel/liteide: Simple, open source, cross-platform Go IDE

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210450

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich at FreeBSD.org

--- Comment #5 from Jan Beich <jbeich at FreeBSD.org> ---
Can you do i386 and QT5=on builds using poudriere as well? Both at least on
9.3-RELEASE-*.

> XGH_PROJECT=	liteide

Drop this (default) line.

> XUSES=		qmake
> XQT4_USE=	QT4=corelib,gui,network,webkit,xml,moc_build,rcc_build,uic_build
> XQT5_USE=	QT5=core,gui,widgets,network,webkit,xml,printsupport,buildtools_build

Having option helpers in different or non-optional sections is... visually
confusing.

> XOPTIONS_RADIO=		QT
> XOPTIONS_RADIO_QT=	QT4 QT5

As USES=qmake requires either USE_QT4 or USE_QT5 you need OPTIONS_SINGLE
instead, or move USES=qmake into option helpers. Otherwise, QT4=off + QT5=off
leads to

  $ make
  ===>  liteide-30.1 'USES+= qmake' must be accompanied with 'USE_QT[]=.
  *** Error code 1

> X.include <bsd.port.options.mk>
> X
> X.if ${PORT_OPTIONS:MQT5}
> XUSE_GL+=	gl
> X.endif

Can you convert this into option helpers?

> Xpost-install-DOCS-on:
> X	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> X.for d in ${PORTDOCS}
> X	${INSTALL_DATA} ${WRKSRC:H}/${d} ${STAGEDIR}${DOCSDIR}
> X.endfor

COPYTREE_SHARE would be more concise e.g.,

  post-install-DOCS-on:
        (cd ${WRKSRC:H} && ${COPYTREE_SHARE} \
                "${PORTDOCS}" ${STAGEDIR}${DOCSDIR})

-- 
You are receiving this mail because:
You are the assignee for the bug.