[Bug 210876] multimedia/assimp: Update to 3.3

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210876

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yuri at rawbw.com
 Attachment #172218|                            |maintainer-approval?(yuri at r
              Flags|                            |awbw.com)

--- Comment #3 from lightside <lightside at gmx.com> ---
Created attachment 172218
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172218&action=edit
Proposed patch (since 416829 revision)

Hello Yuri Victorovich and Kurt Jaeger.

I noticed this PR recently and analyzed changes for v3.3 release tag:
https://github.com/assimp/assimp/releases/tag/v3.3
https://github.com/assimp/assimp/compare/v3.2...v3.3
I found, that developers didn't (or forgot to) change ASSIMP_VERSION_MINOR from
2 to 3:
https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f178/CMakeLists.txt#L49
while they changed value of MinorVersion variable to 3:
https://github.com/assimp/assimp/commit/19769eef8b9612a82fdb55c245db871476e7f178
Because of this, I propose to use GH_TAGNAME, in case of possible re-tag:
https://github.com/assimp/assimp/compare/v3.2...19769ee

The patch in attachment #172181 contains changes for
files/patch-include_assimp_Compiler_pstdint.h file, which updates
include/assimp/Compiler/pstdint.h file from 0.1.12 (in sources) to 0.1.15.4
version. Looks like, the patch changes whole file, instead of concrete lines.
Therefore, I propose patch, which created by `make makepatch` command, but with
some changes "to remove comments with private information". The 0.1.12 version
(with custom changes, based on private information and strange wording in
comments) was proposed by afiskon, for reference:
https://github.com/assimp/assimp/issues/795

Also, I think (and tested this), this version doesn't require devel/boost-libs
library dependency and BOOST option, while there are some traces of "boost"
words in sources, but no ASSIMP_ENABLE_BOOST_WORKAROUND cmake's option, as it
was before 3.3 version. It requires C++11 features:
https://github.com/assimp/assimp/blob/19769eef8b9612a82fdb55c245db871476e7f178/CMakeLists.txt#L117
which may require to add compiler:c++11-lang to USES.

The proposed patch attached, with following changes (including maintainer's
changes):
- Use GH_TAGNAME for current version
- Remove BOOST option and add compiler:c++11-lang to USES
- Add sed patch to change ASSIMP_VERSION_MINOR from 2 to 3 for CMakeLists.txt
file
- Add patch for code/BlenderTessellator.cpp file
- Adapt patch for include/assimp/Compiler/pstdint.h file
- Adapt pkg-plist

-- 
You are receiving this mail because:
You are the assignee for the bug.