[Bug 206526] [NEW PORT] comms/openzwave: Open-source interface to Z-Wave networks

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206526

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |feature, needs-qa, patch
            Summary|[NEW PORT]: comms/openzwave |[NEW PORT] comms/openzwave:
                   |- An open-source interface  |Open-source interface to
                   |to Z-Wave networks          |Z-Wave networks

--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks Johan

Review items:

* Remove "Open-zwave - An " from COMMENT. portlint should have picked this up
(You can also enable PORTLINT in poudriere)

* Look like the PORTVERSION should be 1.4 (or theyre not tagging their repo
properly)
* Use DISTVERSIONPREFIX=v, then you wont need to override GH_TAGNAME
* DOXYGEN option should be named the standard: DOCS. What DOCS depends on is
immaterial.
* Use an OPTIONS helper instead of the .if ${PORT_OPTIONS:MDOXYGEN} block
* Whitespace align Makefile entries
* Add LICENSE_FILE if one exists in WRKSRC

-- 
You are receiving this mail because:
You are the assignee for the bug.