[Bug 206337] Fix devel/dee build with clang 3.8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206337

            Bug ID: 206337
           Summary: Fix devel/dee build with clang 3.8.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: olivierd at FreeBSD.org
          Reporter: dim at FreeBSD.org
          Assignee: olivierd at FreeBSD.org
             Flags: maintainer-feedback?(olivierd at FreeBSD.org)

Created attachment 165718
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=165718&action=edit
Parenthesize journal_iter_is_removed macro so it doesn't cause warnings

During the exp-run in bug 206074, it was found that devel/dee gives errors with
a recent clang 3.8.0 snapshot:

dee-transaction.c:1245:17: error: logical not is only applied to the left hand
side of this comparison [-Werror,-Wlogical-not-parentheses]
      g_assert (!journal_iter_is_removed (jiter));
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/glib-2.0/glib/gtestutils.h:106:59: note: expanded from macro
'g_assert'
                                             if G_LIKELY (expr) ; else \
                                                          ^~~~
/usr/local/include/glib-2.0/glib/gmacros.h:325:59: note: expanded from macro
'G_LIKELY'
#define G_LIKELY(expr) (__builtin_expect (_G_BOOLEAN_EXPR(expr), 1))
                                                          ^~~~
/usr/local/include/glib-2.0/glib/gmacros.h:319:8: note: expanded from macro
'_G_BOOLEAN_EXPR'
   if (expr)                                    \
       ^~~~
dee-transaction.c:1245:17: note: add parentheses after the '!' to evaluate the
comparison first
dee-transaction.c:1245:17: note: add parentheses around left hand side
expression to silence this warning
1 error generated.

This is because the journal_iter_is_removed() macro does not have parentheses
around its expression.  Here is a patch to fix that.

-- 
You are receiving this mail because:
You are the assignee for the bug.