[Bug 206060] Mk/Uses/drupal.mk bug! sets options (comes after bsd.ports.options.mk)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Jan 11 08:52:52 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206060

--- Comment #9 from commit-hook at freebsd.org ---
A commit references this bug:

Author: marino
Date: Mon Jan 11 08:51:52 UTC 2016
New revision: 405770
URL: https://svnweb.freebsd.org/changeset/ports/405770

Log:
  Remove OPTIONS_DEFINE out of Mk/Uses/drupal.mk (affects many drupal ports)

  The USES= fragments are not supposed to modify OPTIONS_* because they are
  loaded after bsd.options.mk.

  In the particular case of drupal, this resulted in SELECTED_OPTIONS and
  DESELECTED_OPTIONS being incorrect.  A second problem was that the "="
  was used for assignment rather than "?=", meaning that any port with
  USES=drupal got their options overwritten at some point (this included
  the main www/drupal6 and www/drupal7 ports).

  This commit adds OPTIONS_DEFINE=DOCS to almost every port that had set
  USES=drupal to correct the mistake of setting options in Mk/Uses.

  PR:   206060

Changes:
  head/Mk/Uses/drupal.mk
  head/www/drupal6-advanced_help/Makefile
  head/www/drupal6-cck/Makefile
  head/www/drupal6-chaos/Makefile
  head/www/drupal6-ckeditor/Makefile
  head/www/drupal6-content_access/Makefile
  head/www/drupal6-geshifilter/Makefile
  head/www/drupal6-google_analytics/Makefile
  head/www/drupal6-image/Makefile
  head/www/drupal6-imce/Makefile
  head/www/drupal6-menu_block/Makefile
  head/www/drupal6-mimedetect/Makefile
  head/www/drupal6-nice_menus/Makefile
  head/www/drupal6-nodewords/Makefile
  head/www/drupal6-page_title/Makefile
  head/www/drupal6-panels/Makefile
  head/www/drupal6-path_redirect/Makefile
  head/www/drupal6-pathauto/Makefile
  head/www/drupal6-print/Makefile
  head/www/drupal6-seo_checklist/Makefile
  head/www/drupal6-services/Makefile
  head/www/drupal6-tagadelic/Makefile
  head/www/drupal6-token/Makefile
  head/www/drupal6-views/Makefile
  head/www/drupal6-webform/Makefile
  head/www/drupal6-wysiwyg/Makefile
  head/www/drupal6-zeropoint/Makefile
  head/www/drupal7-wysiwyg/Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list