[Bug 206060] Mk/Uses/drupal.mk bug! sets options (comes after bsd.ports.options.mk)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206060

            Bug ID: 206060
           Summary: Mk/Uses/drupal.mk bug!  sets options (comes after
                    bsd.ports.options.mk)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: marino at FreeBSD.org
                CC: freebsd-ports-bugs at FreeBSD.org

With any drupal port, the new SELECTED_OPTIONS and DESELECTED_OPTIONS are
broken.

> cd /usr/ports/www/drupal6-token
> make showconfig

===> The following configuration options are available for
drupal6-token-6.x.1.12_1:
     DOCS=on: Build and/or install documentation
===> Use 'make config' to modify these settings

make -V SELECTED_OPTIONS -V DESELECTED_OPTIONS
(returns 2 blank rows)

The cause is because Mk/Uses/drupal.mk is manipulating the options definitions
AFTER bsd.port.options.mk is included (and thus *SELECTED_OPTIONS have been
evaluated)

.if ${_DRUPAL_COMP}
_USES_POST+=    drupal
PKGNAMEPREFIX=  drupal${_DRUPAL_VERSION}-
.if defined(DOC_FILES)
OPTIONS_DEFINE= DOCS
.endif

# drupal contributions must be licensed under the GPLv2 or GPLv3.  This is
# documented at: http://drupal.org/licensing/faq/
.if !defined(LICENSE)
LICENSE=        GPLv2 GPLv3
LICENSE_COMB=   dual
.endif


After speaking with bdrewery about the idea of relocating the *SELECTED_OPTIONS
evaluations to bsd.port.mk, he indicated that he believed it is an error to use
Mk/Uses to change options and that in his opinion, Drupal is what needs
changing.

He also pointed out that drupal.mk also makes the mistake of of assigning
OPTIONS_DEFINE with "=" rather than "+=" which overwrites any previous options
definitions (strike two)


This PR is to request that DOCS be moved back to the individual ports and
secondarily portmgr/documentation guys should specifically document that
OPTIONS in Mk/Uses is verboten.

-- 
You are receiving this mail because:
You are on the CC list for the bug.