[Bug 206019] gtk icon cache not updated for python ports

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206019

            Bug ID: 206019
           Summary: gtk icon cache not updated for python ports
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: henry.hu.sh at gmail.com
                CC: freebsd-ports-bugs at FreeBSD.org

For a python port which uses gtk and installs icons, gtk-update-icon-cache is
not executed.
The plist for such ports is automatically generated, and it seems like that the
check for icons happens before the real plist is generated.

Let's take deskutils/syncthing-gtk as an example. The check for icons happens
in bsd.gnome.mk:
.  if defined(INSTALLS_ICONS)
        @${RM} -f ${TMPPLIST}.icons1
        @for i in `${GREP} "^share/icons/.*/" ${TMPPLIST} | ${CUT} -d / -f 1-3
| ${SORT} -u`; do \
                ${ECHO_CMD} "@rmtry $${i}/icon-theme.cache" \
                        >> ${TMPPLIST}.icons1; \
                ${ECHO_CMD} "@postexec ${LOCALBASE}/bin/gtk-update-icon-cache
-q -f %D/$${i} 2>/dev/null || /usr/bin/true" \
                        >> ${TMPPLIST}; \
                ${ECHO_CMD} "@postunexec ${LOCALBASE}/bin/gtk-update-icon-cache
-q -f %D/$${i} 2>/dev/null || /usr/bin/true" \
                        >> ${TMPPLIST}; \
        done

However, if we insert "cat ${TMPPLIST}" before the "@for", you can see that
cat /usr/ports/deskutils/syncthing-gtk/work/.PLIST.mktmp
/usr/local/share/licenses/syncthing-gtk-0.8/catalog.mk
/usr/local/share/licenses/syncthing-gtk-0.8/LICENSE
/usr/local/share/licenses/syncthing-gtk-0.8/GPLv2

so the plist is not yet filled, and no icon is detected. As a result,
gtk-update-icon-cache is not executed, and the new icons cannot be used by the
applications.

-- 
You are receiving this mail because:
You are on the CC list for the bug.