[Bug 212004] net/freerdp: Update to 2.0.0.d

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212004

--- Comment #15 from Dmitry Marakasov <amdmi3 at FreeBSD.org> ---
Glancing through the patch:

- You don't need manual manpage compression, frameworks handles that, so no
MANPAGE and no post-install: are needed
- PORT_OPTIONS:MGSTREAMER/PORT_OPTIONS:MX11 may be switched to options helpers,
e.g. GSTREAMER_CMAKE_ON, X11_CMAKE_ON (though it also looks to me that the
logic in the patch is inversed, e.g. it needs
GSTREAMER_CMAKE_ON/X11_CMAKE_OFF).
- Since you're using synthetic version number, better go with 2.0.0.a, as
2.0.0.a < 2.0.0 < 2.0.0a - updating from 2.0.0.a to 2.0.0 when it's release
won't require a PORTEPOCH bump

- Most importantly, since it's major version bump and include path change, it
may and will probably break all dependent ports - these should be checked and
bumped.

Since this is an unstable version and may affect other ports, please consider
adding this as another port, e.g. net/freerdp2 or net/freerdp-devel. This will
resolve potential compatibility problems, but you'll need some extra hacks to
make two ports coexist - that is, rename conflicting files. It looks that these
are only executable files (simple MV in post-patch will do) and libraries
(strange that upstream hasn't renamed them while they should've as they have
renamed include directoty and pkgconfig files). This is better to be done
through CMakeLists.txt modification, as not only .so files need to be renamed
but SONAME compiled in them changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.