[Bug 203204] [NEW PORT] databases/pgmodeler: PostgreSQL Database Modeler

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203204

Raphael Kubo da Costa <rakuco at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |In Progress

--- Comment #8 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
Hi there,

Sorry for the absence. I've finally taken a look at the latest patch (0.8.2)
and only have some comments with things that should be improved before landing:
- You don't need both USES=qmake and USE_QT5=qmake_build; USES=qmake is enough.
- GH_ACCOUNT=pgmodeler is redundant; the ports framework uses ${PORTNAME} by
default.
- You should just use "lib" instead of the occurrences of "%%QT_LIBDIR%%" in
pkg-plist. The latter should be used only by the Qt ports themselves in
general.

Thanks for the work; again, I apologize for taking so long to review the patch,
at least we're really close now!

-- 
You are receiving this mail because:
You are the assignee for the bug.