[Bug 211630] audio/libmusicbrainz5 crash when used from libkcddb

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211630

            Bug ID: 211630
           Summary: audio/libmusicbrainz5 crash when used from libkcddb
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: jhale at FreeBSD.org
          Reporter: groot at kde.org
             Flags: maintainer-feedback?(jhale at FreeBSD.org)
          Assignee: jhale at FreeBSD.org

Created attachment 173365
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173365&action=edit
Patch adding visibility to C++ exceptions

See also upstream report http://tickets.musicbrainz.org/browse/LMB-43

Applications using libkcddb crash when libmusicbrainz5 throws an error while
looking up the CD info (e.g. connection error, or unknown CD).

The problem is that libmusicbrainz5 throws a (C++) exception. libkcddb catches
those exceptions and returns an error code instead. But with
-fvisibility=hidden (the default in compiling KDE code), the exception symbols
are hidden, libkcddb can't catch the exceptions and they propagate to the
calling application, which gets an unexpected exception and crashes.

The nicest place to patch this is in libmusicbrainz5, to ensure that the
exception symbols are always visible (so that libkcddb and possibly other users
of libmusicbrainz5 can catch the exceptions reliably).

The attached patch adds a visibility-attribute to the exception symbols, and
prevents crashes that have been reported against KDE applications on FreeBSD
(e.g. PR 209696).

-- 
You are receiving this mail because:
You are the assignee for the bug.