[Bug 211623] [PATCH] Mk/Scripts/do-fetch fails when DISTDIR is symlink

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Aug 6 11:34:35 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211623

            Bug ID: 211623
           Summary: [PATCH] Mk/Scripts/do-fetch fails when DISTDIR is
                    symlink
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: bugzilla.freebsd at omnilan.de
                CC: freebsd-ports-bugs at FreeBSD.org
          Keywords: patch

Created attachment 173355
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173355&action=edit
Patch do-fetch.sh to do mkdir DISTDIR only if onexistant

In do-fetch.sh, there's a unconditional 'mkdir -p "${dp_DISTDIR}"'
This doesn't work if ${DISTDIR} exists and is a symbolic link.
I'm not aware of problems with DISTDIR beeing a symlink, so here's a patch
which only does 'mkdir' if DISTDIR doesn't exist at all – no checks for
read/write permissions suitable at that point, nor if the link is dead.
Further check's shouldn't be affected, if there are any in place (long time ago
I included own Makefiles doing such checks because they were missing at that
time – haven't checked if that changed during the last 5 years)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list