[Bug 208958] net/rsync: fixing the ICONV option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208958

            Bug ID: 208958
           Summary: net/rsync: fixing the ICONV option
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ehaupt at FreeBSD.org
          Reporter: mat at FreeBSD.org
                CC: tijl at FreeBSD.org
          Assignee: ehaupt at FreeBSD.org
             Flags: maintainer-feedback?(ehaupt at FreeBSD.org)

I don't exactly know when it stopped working, or if it ever worked on 10.x, but
last week, I tried to use rsync with "--iconv=UTF-8,US-ASCII//IGNORE//TRANSLIT"
(it translitterates letters like é to 'e to ß to ss if it can, and drop them if
it cannot) to transfer files from a utf-8 host to a crappy old file server.

So, anyway, I updated my crappy old file server to 10.3, and that command
stopped working, saying that the remote rsync did not support --iconv, so, I
had a look and changed the :

.if empty(ICONV_LIB)
CONFIGURE_ARGS+=ac_cv_search_libiconv_open=no
.endif

to

.if ! ${PORT_OPTIONS:MICONV}
CONFIGURE_ARGS+=ac_cv_search_libiconv_open=no
.endif

rebuilt, and there, it had iconv support again, and I was happy and all.

But something else is fishy, today, net/rabbitmq failed to build in poudriere
because:

Shared object "libiconv.so.2" not found, required by "rsync"

Some head scratching, and I found out that there only is a BUILD_DEPENDS on
converters/libiconv, so, rsync is built with it, but depends is not registered,
if I build it in poudriere testport -i, in the shell, I can remove libiconv
because nothing depends on it, and then:

root at 10amd64-ports:~ # pkg check -Ba
Checking all packages:  66%
(rsync-3.1.2_2) /usr/local/bin/rsync - required shared library libiconv.so.2
not found
Checking all packages: 100%
root at 10amd64-ports:~ #

I'm not sure how to fix this, I'm tempted to change the ICONV_USES=iconv line
in rsync's Makefile to ICONV_USES=iconv:translit, but I'm wondering if there's
not some bug somewhere in Mk/Uses/iconv.mk's logic, and it should be fixed
there.

(adding Tijl to the cc because he's the one who did the last change to
iconv.mk)

-- 
You are receiving this mail because:
You are the assignee for the bug.