[Bug 203639] security/krb5: readline not enabled by option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203639

--- Comment #2 from John Hein <z7dr6ut7gs at snkmail.com> ---
I was partly wrong.  My description of the way to show the problem wasn't quite
right - the CONFIGURE_ARGS were correct, but LIB_DEPENDS was not.

But the core problem that readline.mk is not included when using
.pre.mk/.post.mk is valid.

Try reverting the krb5/Makefile before your 2015-10-19 changes in r399631, or
just temporarily modify krb5/Makefile to use .include <bsd.port.pre.mk> &
.include <bsd.port.post.mk>  (instead of using bsd.port.options.mk &
bsd.port.mk which were in the suggested patch here and also part of the r399631
changes).

Then if you do 'make -V LIB_DEPENDS', you should see that devel/readline is not
in the list of LIB_DEPENDS.

To further illustrate the issue, you could also add a .warning in
Mk/Uses/readline.mk.  Then run the 'make -V LIB_DEPENDS' again and see that
readline.mk is never included.

Then use bsd.port.options.mk/bsd.port.mk (instead of .pre.mk/.post.mk) with the
.warning still in readline.mk.  You should observe that readline.mk is then
included.

This happens generally when one uses .pre.mk/.post.mk and test for PORT_OPTIONS
in the port Makefile before .post.mk.  This is why the typical idiom will
include bsd.port.options.mk before the PORT_OPTIONS tests.  This is harder to
notice for USES=readline, because the effects of missing readline.mk are
typically not catastrophic in most cases these days - since
/usr/lib/libreadline.so almost always exists at the moment unless you're using
-current and have a world built WITHOUT_BINUTILS and WITHOUT_GDB _and_ you
don't have the readline port installed _and_ the port in question doesn't
detect the missing readline lib and handle it gracefully.  Those are lots of
conditions necessary to cause the missed readline.mk include to be noticed by
the typical observer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.