[Bug 198921] WRKSRC problems with DISTVERSION != GH_TAGNAME

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198921

            Bug ID: 198921
           Summary: WRKSRC problems with DISTVERSION != GH_TAGNAME
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: xmj at FreeBSD.org
                CC: freebsd-ports-bugs at FreeBSD.org

With the new USE_GITHUB syntax, there can arise the edgecase that a port
defines

PORTVERSION= X.Y.Z
GH_TAGNAME= v${PORTVERSION},

and implicitly sets WRKSRC to ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME_SANITIZED}
(Mk/bsd.port.mk line 1562).

According to the archive downloaded from GitHub, the legitimate directory would
be

WRKSRC= ${WRKDIR}/${GH_PROJECT}-${DISTVERSION}.

However, due to GH_TAGNAME being set (conditional in bsd.port.mk:L1561), this
is not the case.

Given that this most likely affects all 138 ports that set

GH_TAGNAME=    v${PORTVERSION},

a good solution to this in the Mk/ space would be appreciated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.