[Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379

--- Comment #15 from Chris Hutchinson <portmaster at bsdforge.com> ---
(In reply to Chris Hutchinson from comment #14)
> (In reply to Kubilay Kocak from comment #3)
> > Don't forget ncurses can come from Base *or* Ports. If you can support both,
> > do so. If you can't, you still want to test both scenarios.
> 
> Thank you very much for taking the time to review
> this, Kubilay Kocak.
> *curses is not an option, and as it is, it will happily
> use whichever (base, or ports) is available.
> 
> As to the COMMENT; I modified it so that it better
> reflected the *current* features/functions. As the
> original one [currently] "misses the mark".
> 
> As to:
> install-target v. ${STRIP_CMD}
> install-strip wasn't honored (portlint complained)
> but ${STRIP_CMD} made portlint happy. I'll remove
> INSTALL_TARGET* as it's redundant.
> 
> Thanks again, Kubilay Kocak!
> 
> --Chris
> (In reply to f0andrey from comment #12)
> > (In reply to Chris Hutchinson from comment #9)
> > >> 3) As per original review: STRIP_CMD should take place in post-install.
> > >> There is still a pre-install: STRIP_CMD
> > > 
> > > Tried that originally, but there were issues (see additional QA log for
> > > details).
> > 
> > This recording allows you to transfer strip of "pre-install:" in
> > "post-install:"
> > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/liboping.so.0.2.11
> I submitted an updated svn diff to reflect the changes in
> response to this comment.
> But bugzilla crashed, complaining about being unable to
> send an email to the maintainer (matt at peterson.org).
> So I'm just replying again, in hopes bugzilla doesn't
> crash this time.
> 
> Thanks!
> 
> --Chris

Does this look alright now?

Thanks!

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.