[Bug 198777] print/cups-base: XDG_OPEN option not functioning as intended

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198777

            Bug ID: 198777
           Summary: print/cups-base: XDG_OPEN option not functioning as
                    intended
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: jlw at xinuos.com

Created attachment 154635
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=154635&action=edit
Patch for print/cups-base/Makefile

Bug in print/cups-base Makefile. Around the time of CUPS 1.4, the build was
changed to use xdg-open command, when available, for the web interface. At that
time the default command in desktop/cups.desktop.in was revised to use a
variable controlled/set by the configure script. The configure script was
revised to check for the existence of the xdg-open binary on the system an set
the variable to either htmlview or xdg-open accordingly.

Since this ports source change, the Makefile line to edit the cups/desktop.in
prior to beginning the build is non-functional.

.if ${PORT_OPTIONS:MXDG_OPEN}
        @${REINPLACE_CMD} -e 's|htmlview|xdg-open|'
${WRKSRC}/desktop/cups.desktop.in
.endif

The use of xdg-open (devel/xdg-utils) is specified as a run time dependency and
will only be built, if not already on the system, AFTER cups-base has been
built. It is hit or miss whether xdg-open is actually used as configured. It
will never be used when built in a poudriere jail.

A quick patch to the Makefile has been prepared to revise the edit line to
replace the configure variable - @CUPS_HTMLVIEW@ - and is attached.

A more proper fix would be to revise xdg-open from a RUN_DEPENDS to a USES
dependency.  That of course would require additions to Mk/Uses/

-- 
You are receiving this mail because:
You are the assignee for the bug.