[Bug 198379] net/liboping: Update to 1.8.0, Fix MASTER_SITES, WWW, Request MAINTAINER'ship

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198379

--- Comment #9 from Chris Hutchinson <portmaster at bsdforge.com> ---
(In reply to Kubilay Kocak from comment #8)
> Thanks for the update Chris!
No. Thank *you* for taking the time to review this, Kubilay Kocak. :-)
> 
> 1) Add USES=pathfix to fix:
> 
> pkg-plist: +lib/pkgconfig/liboping.pc
> 
> The correct location for .pc files is:
> 
> +libdata/pkgconfig/liboping.pc
> 
> portlint(8) should have picked that up.
> 
> See: Mk/Uses/pathfix.mk

Dunno why, but portlint said nothing. But I have it listed now.
> 
> 2) I still believe the original COMMENT is much better as it matches
> upstream. Minor issue I know, but I personally have a *very* strong
> preference to have ports reflect upstream information as closely as possible
> for user confidence.

I concede (with *minor* amendment). :-)
> 
> 3) As per original review: STRIP_CMD should take place in post-install.
> There is still a pre-install: STRIP_CMD

Tried that originally, but there were issues (see additional QA log for
details).
> 
> 4) While you're there, and if you haven't already:
> 
> Add DEVELOPER=yes in /etc/make.conf to enable extra QA/Sanity checks:
> 
> See: Mk/bsd.sanity.mk
The box I develop on, is only used for development. make.conf(5)
has one line:
DEVELOPER=yes

But, yes. Good advice. :-)

Please see the added QA log, that contains a running dialog.

I think [hope] this satisfies everything.

Thanks, Kubilay Kocak!

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.