[Bug 198190] Fix security/p5-CryptX build with clang 3.6.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198190

            Bug ID: 198190
           Summary: Fix security/p5-CryptX build with clang 3.6.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: vanilla at FreeBSD.org
          Reporter: dim at FreeBSD.org
             Flags: maintainer-feedback?(vanilla at FreeBSD.org)
          Assignee: vanilla at FreeBSD.org

Created attachment 153677
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153677&action=edit
Change inline const rotate functions to macros

During the exp-run in bug 197395, it was found that security/p5-CryptX gives
errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/p5-CryptX-0.021_1.log

These errors all because the embedded copy of libtomcrypt uses the 'I' and 'J'
asm constraints incorrectly.  These can only be used with compile-time integer
constants (e.g. numeric literals).

I propose the attached patch, which changes the ROLc/RORc inline function to
macros, so the constraints requirements are satisfied at compile time.  It is
almost exactly the same as the patch for libtomcrypt itself, in bug 198017.

The produced code is exactly the same, as far as I can determine.  I tested
this on i386 and amd64.

-- 
You are receiving this mail because:
You are the assignee for the bug.