[Bug 200245] comms/owfs: Update to 3.1p0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200245

--- Comment #20 from johan at stromnet.se ---
Okay. If I understand correct, the same compilation is done later in
post-install anyway, since we have to build with the specific hack from
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-python.html.

I did some testing. The optimized files (-O) are not actually built at all,
maybe erased somehow? If I add the following...

    (cd ${STAGEDIR}${PREFIX} \
         && ${PYTHON_CMD} -O ${PYTHON_LIBDIR}/compileall.py \
        -d ${PYTHONPREFIX_SITELIBDIR} -f
${PYTHONPREFIX_SITELIBDIR:S;${PREFIX}/;;})

..I get the following errors:

Error: Orphaned: %%PYTHON_SITELIBDIR%%/ow/__init__.pyo
Error: Orphaned: %%PYTHON_SITELIBDIR%%/ownet/__init__.pyo
Error: Orphaned: %%PYTHON_SITELIBDIR%%/ownet/connection.pyo

Without the above change (only having @${PYTHON_CMD} -O -m compileall
${WRKSRC}), the .pyo files are never installed and thus never orphaned.


My vote is to do the following:

* Remove the do-build section python calls
* Add the above compileall with the -O flag to post-install
* Add .pyo files for each .pyc file in pkg-plist

With those changes, it builds fine here, with .pyo files installed.

To admin at lissyara.su, could you add those minor changes to the patch you've
already created please? Then I think we're good for maintainer-approval.

-- 
You are receiving this mail because:
You are the assignee for the bug.