[Bug 200749] [NEW PORT] devel/sope: Extensive set of GNUstep web application frameworks

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200749

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |euan at potensol.com
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa, patch
            Summary|New port: devel/sope        |[NEW PORT] devel/sope:
                   |                            |Extensive set of GNUstep
                   |                            |web application frameworks
              Flags|                            |maintainer-feedback?(euan at p
                   |                            |otensol.com)

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
Hi Euan, thanks for your submission.

Please include QA results as per my comment in bug 200751 so that this issue
can be progressed as quickly as possible :) portlint in particular will
highlight some of the issues below

A couple of specific review items:

 * For these constructs:

.if ${PORT_OPTIONS:MFOO}
CLAUSE+=        BAR
.endif

Please use the OPTION_CLAUSE= BAR "options helper" syntax. For further details
see: /usr/ports/Mk/bsd.options.mk

 * Make --disable-debug conditional on a DEBUG option
 * LDAP, PGSQL and MYSQL have descriptions already set in bsd.options.desc.mk,
you can remove them
 * Add LICENSE_FILE=${WRKSRC}/path/to/file if a license file exists in the
distribution files
 * @${REINPLACE_CMD} -e 's|/usr/local/pgsql/lib|/usr/local/lib/postgresql|

  Replace hardcoded /usr/local path with LOCALBASE. See:
http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#porting-prefix

-- 
You are receiving this mail because:
You are the assignee for the bug.