[Bug 195313] [maintainer] net/hanstunnel

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Jan 25 18:07:40 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195313

John Marino <marino at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Update] net/hanstunnel     |[maintainer] net/hanstunnel

--- Comment #1 from John Marino <marino at FreeBSD.org> ---
If you are wondering why nobody touched this PR, here are three things hurting
it.


1) This is a maintainer patch, but you didn't put "[maintainer]" in the title. 
This cost you "extra credit" as PRs from maintainers tend to be viewed first. 
I fixed this.

2) you submitted a shar for a port update.  This is against what the handbook
says to do (you are supposed to submit a patch set (1 file) against the port). 
Only a masochist is going to update an existing port with a shar (shar is great
for new ports, not so much for reviewing changes to existing ports)

3) You didn't provide proof of testing, e.g. poudriere logs with stage-qa test.
 While not yet mandatory, committers cherry-pick tested PRs and poudriere bulk
-t is the best testing you can do.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list