[Bug 196435] Prevent @sample keyword from removing user symlinks

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196435

Jan Beich <jbeich at vfemail.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #151209|0                           |1
        is obsolete|                            |

--- Comment #2 from Jan Beich <jbeich at vfemail.net> ---
Created attachment 151216
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151216&action=edit
v2

(In reply to Mathieu Arnold from comment #1)
> Also, for cmp drop the -h, we want symlinks to be followed, otherwise, it'll
> compare the content of the file with the path of the sample file, which, in
> most cases, won't be the same ;-)

Indeed, I've traded one issue for another:

  - symlink target_file vs. regular sample_file (no filetype check)
  - symlink target_file vs. symlink sample_file (no symlink path check)
  - regular target_file vs. regular sample_file
  - regular target_file vs. symlink sample_file

after

  - symlink target_file vs. regular sample_file (path vs. content)
  - symlink target_file vs. symlink sample_file
  - regular target_file vs. regular sample_file
  - regular target_file vs. symlink sample_file (path vs. content)

Let's try to assume target_file cannot be a symlink if unmodified by user or
bug 196432 remains closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.