[Bug 196299] [maintainer] multimedia/xbmc: Rename to kodi, Update to 14.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196299

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jbeich at FreeBSD.org

--- Comment #16 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 152050
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152050
diff of kodi update

pkg-descr still mentions the old name and homepage.

>-MASTER_SITES=	http://mirrors.xbmc.org/releases/source/
>+MASTER_SITES=	http://mirrors.kodi.tv/releases/source/ GH:ffmpeg
>+DISTFILES=  ${DISTVERSION}-Helix${EXTRACT_SUFX} ${GH_PROJECT}-${GH_TAGNAME}.tar.gz:ffmpeg
>+EXTRACT_ONLY=  ${DISTVERSION}-Helix${EXTRACT_SUFX}

Style nits:
- Separate different MASTER_SITES and DISTFILES using a newline
- Tabify whitespace

>+USE_GITHUB=	yes
>+GH_ACCOUNT=	xbmc
>+GH_PROJECT=	ffmpeg
>+GH_COMMIT=	8865ab5
>+GH_TAGNAME=	2.4.4-Helix
>+

Style nit: wrong place to put GH defines according to portlint(1)

>-USE_SDL=	image sdl
>+USE_SDL=	image sdl2

USE_SDL=image implicitly depends on USE_SDL=sdl. Unless kodi links against
both SDL 1.2 and SDL 2.0 change to

  USE_SDL=    image2 sdl2

>-OPTIONS_DEFINE=	AIRPLAY AIRTUNES AVAHI CEC DOCS LAME \
>-		LIBBLURAY HAL LIRC MYSQL NONFREE PULSEAUDIO RTMP SFTP \
>-		SMB VAAPI VDPAU VORBIS WEBSERVER XRANDR

Why LAME, HAL, VORBIS, PULSEAUDIO are removed ? A succinct explanation
for commit message would be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.