[Bug 197330] devel/libcli: needs -Werror flag removed for DragonFly support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197330

            Bug ID: 197330
           Summary: devel/libcli: needs -Werror flag removed for DragonFly
                    support
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: tj at FreeBSD.org
          Reporter: marino at FreeBSD.org
          Assignee: tj at FreeBSD.org
             Flags: maintainer-feedback?(tj at FreeBSD.org)

on the libcli port, the Makefile was patched, specifically this line

-CFLAGS += $(DEBUG) $(OPTIM) -Wall -std=c99 -pedantic -Wformat-security
-Wno-format-zero-length -Werror -Wwrite-strings -Wformat
-fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align
-Wno-unused-parameter
+CFLAGS += -Wall -Wformat-security -Wno-format-zero-length -Werror
-Wwrite-strings -Wformat -fdiagnostics-show-option -Wextra -Wsign-compare
-Wcast-align -Wno-unused-parameter


The "-Werror" flag should have been removed as well.  ON DragonFly:

cc  -pipe -O2 -fno-strict-aliasing -Wall -Wformat-security
-Wno-format-zero-length -Werror -Wwrite-strings -Wformat
-fdiagnostics-show-option -Wextra -Wsign-compare -Wcast-align
-Wno-unused-parameter -fPIC -o clitest.o -c clitest.c
In file included from libcli.c:13:0:
/usr/include/malloc.h:2:2: error: #warning "this file includes <malloc.h> which
is deprecated, use <stdlib.h> instead" [-Werror=cpp]
cc1: all warnings being treated as errors
Makefile:32: recipe for target 'libcli.o' failed


portmgr has issued a blanket to remove Werror as a rule (fyi) because in almost
every cause the warning should not prevent the build from succeeding.

Can the patch be updated to remove -Werror too?

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer tj at FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.