[Bug 199480] [patch] lang/lua52, lang/lua53: use 'arc4random()' instead of 'time()' for string hash seed

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Dec 30 20:08:11 UTC 2015


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199480

Vitaly Magerya <vmagerya at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155642|0                           |1
        is obsolete|                            |

--- Comment #5 from Vitaly Magerya <vmagerya at gmail.com> ---
Created attachment 164875
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=164875&action=edit
lua-arc4random.diff

The update is that the upstream doesn't mind [1].

Also, based on their suggestions, here's a new (less intrusive)
patch.

Note that the new patch fixes what seems to be a mistake in
lang/lua53/files/patch-src__Makefile: currently that file changes
"CFLAGS= ..." into "CFLAGS?= ...", which makes it so that the
"..." part is ignored, and the "MYCFLAGS" variable defined from
lang/lua53/Makefile is never used. Note that the equivalent patch
for lua52 (lang/lua53/files/patch-src__Makefile) does not add
the "?", which is the correct way to do things.

[1] http://article.gmane.org/gmane.comp.lang.lua.general/120118

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list