[Bug 205476] x11-toolkits/wxgtk30 Provide backtrace option to configure

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205476

--- Comment #6 from Chris Hutchinson <portmaster at bsdforge.com> ---
(In reply to Kyle Evans from comment #2)
> Hello!
> 
> The attached patch didn't quite work out as planned- with a minor
> modification to remove the '!empty' while checking PORT_OPTIONS:MBACKTRACE-
> and testing against -CURRENT:
> 
> * Enabling the option enables backtrace as expected
> * Disabling the option disables backtrace as expected
> * The option is defaulted to backtrace disabled as expected
> 
> I will attach the revised version that I effectively used in these tests,
> for the sake of being perfectly explicit about the modification required. Do
> I need to go back to 9.3-RELEASE and 9-STABLE and prove this option is
> effectively a no-op there?

While I *did* examine (and approve) the patch. It looks fine.
I *think* a QA run that proves it's not possible to *enable*
Backtrace on a 9.x system, might be required.
*But* IMHO the patch (svn diff) speaks for itself. :-)

Thanks Kyle!

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.