[Bug 205039] sysutils/pesign: unbreak on pre-10.2 systems

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205039

            Bug ID: 205039
           Summary: sysutils/pesign: unbreak on pre-10.2 systems
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: trasz at FreeBSD.org
          Reporter: jbeich at FreeBSD.org
          Assignee: trasz at FreeBSD.org
             Flags: maintainer-feedback?(trasz at FreeBSD.org),
                    merge-quarterly?

Created attachment 163870
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163870&action=edit
use poll(2) and copy strchrnul(3) from 10.x

Looking at how ppoll(2) is implemented it seems the following is true

  ppoll(,, NULL, NULL) == poll(,, INFTIM)

Our manpage is a bit vague but the one on Linux has

  If the sigmask argument is specified as NULL, then no signal mask
  manipulation is performed (and thus ppoll() differs from poll() only
  in the precision of the timeout argument).

  If timeout_ts is specified as NULL, then ppoll() can block
  indefinitely.

But FreeBSD 9.x also needs another fix

  client.c: In function 'get_token_pin':
  client.c:244:3: error: implicit declaration of function 'strchrnul'
[-Werror=implicit-function-declaration]
     char *c = strchrnul(pin, '\n');
     ^
  client.c:244:13: error: initialization makes pointer from integer without a
cast [-Werror]
     char *c = strchrnul(pin, '\n');
           ^
  client.c:262:13: error: initialization makes pointer from integer without a
cast [-Werror]
     char *c = strchrnul(pin, '\n');
           ^
  cc1: all warnings being treated as errors

poudriere bulk -t build logs:
- 9.3R i386: http://sprunge.us/MaEO
- 9.3R amd64: http://sprunge.us/cTYG
- 10.1R i386: http://sprunge.us/fjGN
- 10.2R amd64: http://sprunge.us/ZfFK
- 11.0C i386: http://sprunge.us/JcIb

Would you like the patch land in /branches/2015Q4 as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.