[Bug 202642] audio/soundtouch: enable INTEGER_SAMPLES on armv6 by default

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202642

            Bug ID: 202642
           Summary: audio/soundtouch: enable INTEGER_SAMPLES on armv6 by
                    default
           Product: Ports & Packages
           Version: Latest
          Hardware: arm
                OS: Any
            Status: New
          Keywords: feature, patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: crees at FreeBSD.org
          Reporter: jbeich at FreeBSD.org
                CC: freebsd-arm at FreeBSD.org
             Flags: maintainer-feedback?(crees at FreeBSD.org)
                CC: freebsd-arm at FreeBSD.org
          Assignee: crees at FreeBSD.org

Created attachment 160330
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160330&action=edit
v0

Gecko wants to use signed 16-bit integer audio samples on ARM for performance
reasons. Unlike bundled version audio/soundtouch uses 32-bit floats by default.
This leads to build failure due to discrepancy of configured sample type.

  dnl
https://dxr.mozilla.org/mozilla-central/rev/ba43a48d3c52/configure.in#5022
  dnl Use integers over floats for audio on B2G and Android
  dnl (regarless of the CPU architecture, because audio
  dnl backends for those platforms don't support floats. We also
  dnl use integers on ARM with other OS, because it's more efficient.
  if test "$OS_TARGET" = "Android" -o "$CPU_ARCH" = "arm"; then
      MOZ_SAMPLE_TYPE_S16=1
      AC_DEFINE(MOZ_SAMPLE_TYPE_S16)
      AC_SUBST(MOZ_SAMPLE_TYPE_S16)
  else
      MOZ_SAMPLE_TYPE_FLOAT32=1
      AC_DEFINE(MOZ_SAMPLE_TYPE_FLOAT32)
      AC_SUBST(MOZ_SAMPLE_TYPE_FLOAT32)
  fi

  // http://sourceforge.net/p/soundtouch/code/226/tree/trunk/include/STTypes.h
  #if (defined(__SOFTFP__) && defined(ANDROID))
      // For Android compilation: Force use of Integer samples in case that
      // compilation uses soft-floating point emulation - soft-fp is way too
slow
      #undef  SOUNDTOUCH_FLOAT_SAMPLES
      #define SOUNDTOUCH_INTEGER_SAMPLES      1
  #endif

$ make -C www/firefox
[...]
checking for soundtouch >= 1.8.0... yes
checking MOZ_SOUNDTOUCH_CFLAGS... -I/usr/local/include/soundtouch   
checking MOZ_SOUNDTOUCH_LIBS... -L/usr/local/lib -lSoundTouch  
checking for soundtouch sample type... float
configure: error: SoundTouch library is built with incompatible sample type.
Either rebuild the library with/without --enable-integer-samples, chase default
Mozilla sample type or remove --with-system-soundtouch.

http://beefy8.nyi.freebsd.org/data/head-armv6-default/p395013_s287011/logs/firefox-40.0_6,1.log

-- 
You are receiving this mail because:
You are the assignee for the bug.