[Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202404

--- Comment #9 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 160285
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160285
v4

> @@ -25,7 +25,6 @@
>  CONFIGURE_ARGS=	--cc=${CC} \
>  		--extra-libs='-lavresample ${PORTAUDIOLIB}' \
>  		--mandir=${PREFIX}/man \
> -		--enable-libavresample \

What's the rationale?

> +OPTIONS_DEFINE=	... V4L ...

If it was previously commented out and didn't work then don't advertise it.
Option helpers can be left uncommented as they wouldn't be used.

> -.if ${PORT_OPTIONS:MIPV6}
> -CATEGORIES+=		ipv6
> -.else
> -CONFIGURE_ARGS+=	--disable-inet6
> -.endif
[...]
> +IPV6_CONFIGURE_ON=	--enable-inet6
> +IPV6_CONFIGURE_OFF=	--disable-inet6

CATEGORIES is lost?

> +ASS_CONFIGURE_OFF=	--disable-libass --disable-enca

Make it ASS_IMPLIES=ENCA instead.

> +CACA_CONFIGURE_ON=	--enable-caca
> +CACA_CONFIGURE_OFF=	--disable-caca

Better replace such instances with the likes of

  CACA_CONFIGURE_ENABLE=    caca

> +THEORA_EXTRA_LIBS=	-ltheoradec
> +V4L_EXTRA_LIBS=		-lv4l2
[...]
> +.if defined(THEORA_EXTRA_LIBS)
> +CONFIGURE_ARGS+=	--extra-libs="${THEORA_EXTRA_LIBS}"
> +.endif
> +.if defined(V4L_EXTRA_LIBS)
> +CONFIGURE_ARGS+=	--extra-libs="${V4L_EXTRA_LIBS}"
> +.endif

This isn't going to work. Each instance of --extra-libs overrides the previous
one. Try using standard variable.

  CONFIGURE_ARGS+= --extra-libs="${LIBS}"
  [...]
  THEORA_LIBS=    -ltheoradec
  V4L_LIBS=    -lv4l2

> -.if ${PORT_OPTIONS:MX11}
> -USE_XORG=		x11 xv xxf86vm
> -.if ${PORT_OPTIONS:MOPENGL}
> -USE_XORG+=		glproto
> -.if ${PORT_OPTIONS:MXINERAMA}
> -USE_XORG+=		xinerama xineramaproto
> +OPENGL_USE=		GL=gl XORG=glproto
> +XINERAMA_USE=		XORG=xinerama,xineramaproto

Lossy conversion. Where are _IMPLIES= X11 ?

> .include <bsd.port.options.mk>

This line should disappear.

> 
> .if ${ARCH} == "sparc64"
> BROKEN=		Does not compile on sparc64
> .endif

Convert into BROKEN_sparc64.

> +--- configure.orig	2013-07-09 16:33:11 UTC
> ++++ configure
[...]
> +-  for _cc in "$_cc" gcc cc ; do
> ++  for _cc in "$_cc" cc cc ; do

Same mistake as v3. You're converting post-patch into files/patch-configure.

-- 
You are receiving this mail because:
You are the assignee for the bug.