[Bug 198864] net/etrace fix MASTER_SITES, update 1.1 ==> 1.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198864

--- Comment #7 from Chris Hutchinson <portmaster at bsdforge.com> ---
(In reply to Jason Unovitch from comment #2)
> Created attachment 159507 [details]
> etrace-1.2.patch
> 
> Chris,
> Patch attached to resolve some issues I came across.
> 
> 1.  PORTREVISION bump was not needed since PORTVERSION got bumped from 1.1
> to 1.2.
> 
> 2.  Change BUILD_DEPENDS to LIB_DEPENDS.  As is the original patch resulted
> in a busted install that didn't bring it's dependencies along with it.
> # ldd /usr/local/bin/etrace
> /usr/local/bin/etrace:
>         libpcap.so.1 => not found (0)
>         libdnet.so.1 => not found (0)
>         libc.so.7 => /lib/libc.so.7 (0x800827000)
> # etrace
> Shared object "libpcap.so.1" not found, required by "etrace"
> 
> 
> Lastly, after the fixing the build/install issues the examples in etrace(8)
> don't work at run time.  Can you help clear up what I may be missing?
> 
> jason at Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All %
> sudo etrace www.example.com                               
> Starting icmp/Echo trace to 93.184.216.34
> etrace: ip_send() failed: Invalid argument
> jason at Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All %
> sudo etrace -T 80 www.example.com
> Starting tcp/80 trace to 93.184.216.34
> etrace: ip_send() failed: Invalid argument
> jason at Silverstone:/usr/local/poudriere/data/packages/110amd64-default/All %
> sudo etrace --udp 53 --data-file @dns 10.100.82.1
> Starting udp/53 trace to 10.100.82.1
> etrace: ip_send() failed: Invalid argument

Closer examination of your patch reveals that the patch isn't against
my proposed version of etrace (1.2).
You are still modifying Makefile.in with files/patch-Makefile.in.
files/patch-Makefile.in no longer exists in the diff I provided
with this PR(1). Because it is no longer needed.

Would you be so kind as to obsolete your diff, Jason?

Thanks!

--Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.